Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rules dnd #301

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Feature/rules dnd #301

merged 2 commits into from
Mar 23, 2024

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 23, 2024

Closes #293

Add a dependency on @formkit/drag-and-drop, to support ordering redirect rules via drag'n'drop

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.98%. Comparing base (18a5413) to head (8106b80).
Report is 12 commits behind head on main.

Files Patch % Lines
src/redirect-rules/ShortUrlRedirectRules.tsx 85.71% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   84.95%   84.98%   +0.02%     
==========================================
  Files         159      159              
  Lines        9898     9904       +6     
  Branches     1365     1363       -2     
==========================================
+ Hits         8409     8417       +8     
  Misses        150      150              
+ Partials     1339     1337       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@acelaya acelaya merged commit 64c9d49 into shlinkio:main Mar 23, 2024
7 checks passed
@acelaya acelaya deleted the feature/rules-dnd branch April 7, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow redirect rules to be ordered via drag'n'drop
1 participant