Simplify visits reducers types with a status discriminator prop #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #874
Replace the multiple boolean flags that determine the status of the visits and visits comparison reducers, with a single status discriminator prop that is less error prone and easier to reason about.
TODO
EDIT: This stopped working because of a race condition in which status is set to canceled, but in-flight requests end up setting it back to loading. Previously, loading and canceled statuses were handled by two different flags, which incidentally worked around this race condition.