Skip to content

Conversation

@acelaya
Copy link
Member

@acelaya acelaya commented Nov 21, 2025

Closes #2555

Update all dev and the prod docker images to PHP 8.5

@acelaya
Copy link
Member Author

acelaya commented Nov 21, 2025

Building the docker image fails, seemingly due to the installation of the MS SQL ODBC. However, this works in CI with ubuntu 🤔

@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.60%. Comparing base (6eb9419) to head (779c0b8).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2534   +/-   ##
==========================================
  Coverage      94.60%   94.60%           
  Complexity      1637     1637           
==========================================
  Files            273      273           
  Lines           5093     5093           
==========================================
  Hits            4818     4818           
  Misses           275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@acelaya
Copy link
Member Author

acelaya commented Nov 21, 2025

Building the docker image fails, seemingly due to the installation of the MS SQL ODBC. However, this works in CI with ubuntu 🤔

Looks like building the docker image worked here. It might be related with my local env.

@acelaya
Copy link
Member Author

acelaya commented Nov 21, 2025

Building the docker image fails, seemingly due to the installation of the MS SQL ODBC. However, this works in CI with ubuntu 🤔

Looks like building the docker image worked here. It might be related with my local env.

Ok, the problem is not MS SQL ODBC, but xdebug. That's why the production image actually builds. Only dev ones fail.

@acelaya acelaya marked this pull request as ready for review December 4, 2025 21:03
@acelaya acelaya marked this pull request as draft December 4, 2025 21:06
@acelaya acelaya force-pushed the 8.5-docker-image branch 2 times, most recently from d01fff2 to be70fe9 Compare December 18, 2025 07:14
@acelaya
Copy link
Member Author

acelaya commented Dec 18, 2025

With the updates to install xdebug with pie, now the remaining error is due to pdo_sqlsrv not yet supporting PHP 8.5 microsoft/msphpsql#1539

This can wait for the new release in January/February 2026, as Shlink 5.0 will not release until around then. If it becomes a blocker, updating docker images to PHP 8.5 can be delayed to Shlink 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update docker images to PHP 8.5

1 participant