-
-
Notifications
You must be signed in to change notification settings - Fork 371
Update docker images to PHP 8.5 #2534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Building the docker image fails, seemingly due to the installation of the MS SQL ODBC. However, this works in CI with ubuntu 🤔 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2534 +/- ##
==========================================
Coverage 94.60% 94.60%
Complexity 1637 1637
==========================================
Files 273 273
Lines 5093 5093
==========================================
Hits 4818 4818
Misses 275 275 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Looks like building the docker image worked here. It might be related with my local env. |
Ok, the problem is not MS SQL ODBC, but xdebug. That's why the production image actually builds. Only dev ones fail. |
3e0a047 to
4ba4063
Compare
d01fff2 to
be70fe9
Compare
|
With the updates to install xdebug with pie, now the remaining error is due to pdo_sqlsrv not yet supporting PHP 8.5 microsoft/msphpsql#1539 This can wait for the new release in January/February 2026, as Shlink 5.0 will not release until around then. If it becomes a blocker, updating docker images to PHP 8.5 can be delayed to Shlink 5.1 |
3bec882 to
779c0b8
Compare
Closes #2555
Update all dev and the prod docker images to PHP 8.5