Fix a11y issues for closing components with focused children #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6 tasks
Contributor
Author
|
@KonnorRogers: |
KonnorRogers
approved these changes
Feb 28, 2025
2 tasks
…-blur # Conflicts: # docs/pages/resources/changelog.md
claviska
added
the
fixed-in-wa
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Shoelace team,
as other people have pointed out, there are some issues with closable components when they have focused slotted children. We already created patches for our own Shoelace fork and I wanted to mirror those back to you in case they are helpful.
This PR adds a new utility function
blurActiveElementthat makes sure the focus for elements is removed when they become invisible.Fixes #2335
Fixes #2283