Skip to content

Conversation

@diervo
Copy link
Contributor

@diervo diervo commented Mar 10, 2025

Fixed the guard on popover to allow virtual contextElement
I assume there was no tests because this was not working as specified in the documentation.

@vercel
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview Mar 10, 2025 4:52pm

Copy link
Member

@claviska claviska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for the PR!

@claviska claviska merged commit 5ef3c91 into shoelace-style:next Mar 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants