-
-
Notifications
You must be signed in to change notification settings - Fork 911
Add JSX Types and Docs #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add JSX Types and Docs #2455
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
👀 very cool. So with this, React 19+ would get type safety on bare custom elements without needing to use our wrappers. Seems like a win to me... |
|
This is amazing, but I really don't like adding |
|
I did not even realize there is a plugin for this now :). We built our own react 19 type wrapper with a couple of lines of JS, using the original custom element manifest provided by shoelace in our "fork" Synergy. It even supports autocompletion for all css variables in the Could port this to shoelace if you are interested. However, I agree an official version with an external package would still be nicer as it may have better support in the long term. |
@claviska are those properties meant to be avaliable for teams to use? Alternatively, you can make the properties |
@schilchSICKAG Very cool! Great minds think alike, I guess. 😉 CSS variables is coming soon to the packag as well. I originally went with a type generator similar to what you have, but I needed to open it up so they would work in any JSX environemnt (preact, stenciljs, etc.), so I had to avoid a dependency on react. |
@break-stuff: Thanks for the explanation. You are right, we currently do not support Preact and this would be difficult to get with react types. Will have a deeper look at your solution, maybe I can port some parts - or even exchange my custom solution. |
This PR adds support for JSX with the following changes: