Skip to content

Conversation

@ggPeti
Copy link

@ggPeti ggPeti commented Jul 23, 2025

When the submenu opens to the right, the safe triangle's position is correct.

image

But when it gets flipped by the underlying floating-ui library, it becomes incorrect:

image

This is because the code checks for the direction style property, which is incorrect - the data-current-placement attribute tells the whole story.

@vercel
Copy link

vercel bot commented Jul 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shoelace ❌ Failed (Inspect) Jul 23, 2025 8:32am

@ggPeti
Copy link
Author

ggPeti commented Jul 28, 2025

Can't see what's wrong with the Vercel deployment. Can someone let me know?

@KonnorRogers
Copy link
Collaborator

@ggPeti its a TypeScript error:

✘ Error: Command failed: tsc --project ./tsconfig.prod.json --outdir "dist"

src/components/menu-item/submenu-controller.ts(198,56): error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'.

Error: Command "npm run build" exited with 1

I also approved a full build which has the somes errors in GH actions with linting as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants