Skip to content

Refactor all machines #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor all machines #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion shogun/structure/DualLibQPBMSOSVM.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ void DualLibQPBMSOSVM::init()
set_solver(BMRM);
}

bool DualLibQPBMSOSVM::train_machine(std::shared_ptr<Features> data)
bool DualLibQPBMSOSVM::train_machine(const std::shared_ptr<Features>& data, const std::shared_ptr<Labels>& labs)
{
require(m_model, "Model has not been set.");
if (!m_w)
Expand Down
2 changes: 1 addition & 1 deletion shogun/structure/DualLibQPBMSOSVM.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ class DualLibQPBMSOSVM : public LinearStructuredOutputMachine
/** train dual SO-SVM
*
*/
bool train_machine(std::shared_ptr<Features> data=NULL) override;
bool train_machine(const std::shared_ptr<Features>& data, const std::shared_ptr<Labels>& labs) override;

private:
/** init parameters
Expand Down