[16.0] [FIX] shopinvader_api_address: Missing rights on address update

[paradoxxxzero]

Same reason as for partner_sudo, on update write is done on address so we may need sudo too.

[lmignon]

@paradoxxxzero In which context? Can you add a test to reproduce the error?

[paradoxxxzero]

One stacktrace says more than a thousand words:

Traceback (most recent call last):
  (...)
  File "/env/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 967, in run
    result = context.run(func, *args)
  File "/odoo/links/shopinvader_api_address/routers/address_service.py", line 92, in update_invoicing_address
    address = helper._update_address(data, "invoicing", address_id)
  File "/odoo/links/shopinvader_api_address/routers/address_service.py", line 236, in _update_address
    updated_address = partner_sudo._update_shopinvader_invoicing_address(
  File "/odoo/links/shopinvader_address/models/res_partner.py", line 92, in _update_shopinvader_invoicing_address
    address.write(vals)
  File "/odoo/src/addons/base_vat/models/res_partner.py", line 674, in write
    return super(ResPartner, self).write(values)
  File "/odoo/links/partner_event/models/res_partner.py", line 38, in write
    res = super(ResPartner, self).write(data)
  File "/odoo/links/partner_contact_address_default/models/res_partner.py", line 50, in write
    return super().write(vals)
  File "/odoo/src/odoo/addons/base/models/res_partner.py", line 582, in write
    result = result and super(Partner, self).write(vals)
  File "/odoo/src/addons/mail/models/mail_activity.py", line 788, in write
    return super(MailActivityMixin, self).write(vals)
  File "/odoo/src/addons/mail/models/mail_thread.py", line 319, in write
    self._prepare_tracking(self._fields)
  File "/odoo/src/addons/mail/models/mail_thread.py", line 527, in _prepare_tracking
    values.setdefault(fname, record[fname])
  File "/odoo/src/odoo/models.py", line 5716, in __getitem__
    return self._fields[key].__get__(self, type(self))
  File "/odoo/src/odoo/fields.py", line 3156, in __get__
    return super().__get__(records, owner)
  File "/odoo/src/odoo/fields.py", line 2493, in __get__
    return super().__get__(records, owner)
  File "/odoo/src/odoo/fields.py", line 1021, in __get__
    record._fetch_field(self)
  File "/odoo/src/odoo/models.py", line 3078, in _fetch_field
    self._read(fnames)
  File "/odoo/src/odoo/models.py", line 3182, in _read
    field.read(fetched)
  File "/odoo/src/odoo/fields.py", line 3167, in read
    lines = comodel.search(domain, limit=self.limit)
  File "/odoo/src/odoo/models.py", line 1712, in search
    res = self._search(args, offset=offset, limit=limit, order=order, count=count)
  File "/odoo/src/odoo/models.py", line 4532, in _search
    model.check_access_rights('read')
  File "/odoo/src/odoo/models.py", line 3348, in check_access_rights
    return self.env['ir.model.access'].check(self._name, operation, raise_exception)
  File "/env/lib/python3.10/site-packages/decorator.py", line 232, in fun
    return caller(func, *(extras + args), **kw)
  File "/odoo/src/odoo/tools/cache.py", line 90, in lookup
    value = d[key] = self.method(*args, **kwargs)
  File "/odoo/src/odoo/addons/base/models/ir_model.py", line 1829, in check
    raise AccessError(msg)
odoo.exceptions.AccessError: Vous n'êtes pas autorisé à accéder aux enregistrements 'Bank Statement Label' (account.statement.label).

Fine tuning of ACL is hard on partners, a lot of modules add functionality that requires read everywhere, and I don’t think we want to give access to Bank Statement Labels to the API user.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (766c202) to head (17f507c).

Additional details and impacted files

@@           Coverage Diff           @@
##             16.0    #1584   +/-   ##
=======================================
  Coverage   94.89%   94.90%           
=======================================
  Files         514      514           
  Lines       10665    10668    +3     
  Branches      547      547           
=======================================
+ Hits        10121    10124    +3     
  Misses        392      392           
  Partials      152      152           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.