Skip to content

Conversation

@paradoxxxzero
Copy link
Contributor

@paradoxxxzero paradoxxxzero commented Jun 5, 2025

From shopinvader/odoo-shopinvader-payment#99

Automatically converts the cart into a sale when the payment is authorized, set as pending, or done instead of relying on callback, see shopinvader/odoo-shopinvader-payment#101

@codecov
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

❌ Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.72%. Comparing base (d50ac1d) to head (2670223).
⚠️ Report is 33 commits behind head on 16.0.

Files with missing lines Patch % Lines
sale_cart/models/payment_transaction.py 50.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             16.0    #1599      +/-   ##
==========================================
- Coverage   94.79%   94.72%   -0.07%     
==========================================
  Files         507      509       +2     
  Lines       10486    10505      +19     
  Branches      542      542              
==========================================
+ Hits         9940     9951      +11     
- Misses        394      402       +8     
  Partials      152      152              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sebastienbeau sebastienbeau added this to the 16.0 milestone Aug 29, 2025
@paradoxxxzero paradoxxxzero marked this pull request as ready for review September 1, 2025 14:06
Copy link
Contributor

@sebastienbeau sebastienbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (code review)

Note: we should merge the PR on payment: shopinvader/odoo-shopinvader-payment#101 at the same time to avoid weird behavior

Copy link
Contributor

@bguillot bguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code review

@sebastienbeau
Copy link
Contributor

/ocabot merge minor

@shopinvader-git-bot
Copy link

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1599-by-sebastienbeau-bump-minor, awaiting test results.

shopinvader-git-bot pushed a commit that referenced this pull request Dec 16, 2025
Signed-off-by sebastienbeau
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants