-
Notifications
You must be signed in to change notification settings - Fork 110
[16.0] [IMP] sale_cart: Automatically convert cart to sale when a payment is authorized, set as pending, or done. #1599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
Conversation
… authorized, set as pending, or done.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #1599 +/- ##
==========================================
- Coverage 94.79% 94.72% -0.07%
==========================================
Files 507 509 +2
Lines 10486 10505 +19
Branches 542 542
==========================================
+ Hits 9940 9951 +11
- Misses 394 402 +8
Partials 152 152 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastienbeau
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (code review)
Note: we should merge the PR on payment: shopinvader/odoo-shopinvader-payment#101 at the same time to avoid weird behavior
bguillot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code review
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
From shopinvader/odoo-shopinvader-payment#99
Automatically converts the cart into a sale when the payment is authorized, set as pending, or done instead of relying on callback, see shopinvader/odoo-shopinvader-payment#101