[16.0] shopinvader_anonymous_partner: make deletation asynchronious #1605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default there is too many missing index in odoo core and on big database deleting a partner is slow as not all intergrator optimize their database delete it in background by default
sebastienbeau
changed the title
Contributor
Author
|
I will fix the test (just need to adapt them as it's now a job) But I would like to have your feedback before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default there is too many missing index in Odoo core (also in OCA module) and on big database deleting a partner is super slow (1/2s). And it's not a common user action, so most of the time we do not care.
For sure we always have to optimize request, but I fear that new comer that test Shopinvader will just have a super bad experience. If they test it on an existing database it will be slow in 99% of case if there have a big db =W so their will just intepret that shopinvader is slow.
As we always have queue job installed, maybe it can be an acceptable dependency and solution to delete this record in background.
@lmignon @paradoxxxzero @sbidoul need your feedback (I do not have a strong opinion on this one)