Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #405, where
json:",omitzero"can behave incorrectly when Decimal is inside nested structs.I followed the approach discussed in the issue and added a
getValuefunc. It returns the already-initializedzeroIntwhend.value == nil, so zero-value Decimal is handled consistently instead of leaving each call site to guard for nil.I couldn’t find a cleaner option that didn’t spread the same logic around the codebase.
There may be a small performance cost from doing
if d.value == nilchecks a bit more often, but I think that tradeoff is worth it for correctness and better developer experience.