Skip to content

Conversation

@cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Mar 19, 2025

The WebhookSystemConfigHelper was fed with a wrongly structured config array. A correctly structured array is now used, in addition to:

  • Check webhook only if a config value will change
  • Check for all route expect our route which already handled it, catching also cases where the system config is written via commands or yaml

fixes shopware/shopware#7537

@cyl3x cyl3x requested review from Bird87ZA, mitelg and mstegmeyer March 19, 2025 12:31
@cyl3x cyl3x self-assigned this Mar 19, 2025
@cyl3x cyl3x force-pushed the fix/system-config-webhook-check branch from 758a94a to daedb68 Compare March 19, 2025 12:32
mitelg
mitelg previously approved these changes Mar 19, 2025
Copy link
Member

@mitelg mitelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

mstegmeyer
mstegmeyer previously approved these changes Mar 19, 2025
Bird87ZA
Bird87ZA previously approved these changes Mar 19, 2025
@cyl3x cyl3x merged commit f8f9d8e into trunk Mar 19, 2025
12 checks passed
@cyl3x cyl3x deleted the fix/system-config-webhook-check branch March 19, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Cloud] System-Config Entity can not be saved

5 participants