Skip to content

fix: system config webhook check #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 19, 2025
Merged

fix: system config webhook check #174

merged 5 commits into from
Mar 19, 2025

Conversation

cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Mar 19, 2025 •
edited by mstegmeyer
Loading

The WebhookSystemConfigHelper was fed with a wrongly structured config array. A correctly structured array is now used, in addition to:

  • Check webhook only if a config value will change
  • Check for all route expect our route which already handled it, catching also cases where the system config is written via commands or yaml

fixes shopware/shopware#7537

@cyl3x cyl3x requested review from Bird87ZA, mitelg and mstegmeyer March 19, 2025 12:31
@cyl3x cyl3x self-assigned this Mar 19, 2025
@cyl3x cyl3x force-pushed the fix/system-config-webhook-check branch from 758a94a to daedb68 Compare March 19, 2025 12:32
mitelg
mitelg previously approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@mitelg mitelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@cyl3x cyl3x requested a review from mitelg March 19, 2025 14:06
mstegmeyer
mstegmeyer previously approved these changes Mar 19, 2025
View reviewed changes
@cyl3x cyl3x requested review from Bird87ZA and mstegmeyer March 19, 2025 14:39
Bird87ZA
Bird87ZA previously approved these changes Mar 19, 2025
View reviewed changes
@cyl3x cyl3x merged commit f8f9d8e into trunk Mar 19, 2025
12 checks passed
@cyl3x cyl3x deleted the fix/system-config-webhook-check branch March 19, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bird87ZA Bird87ZA Bird87ZA approved these changes

@mitelg mitelg mitelg approved these changes

@mstegmeyer mstegmeyer Awaiting requested review from mstegmeyer

Assignees

@cyl3x cyl3x

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cloud] System-Config Entity can not be saved
4 participants
@cyl3x @Bird87ZA @mitelg @mstegmeyer