Skip to content

[6.6.x] fix: system config webhook check #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

cyl3x
Copy link
Contributor

@cyl3x cyl3x commented Mar 19, 2025

The WebhookSystemConfigHelper was fed with a wrongly structured config array. A correctly structured array is now used, in addition to:

  • Check webhook only if a config value will change
  • Check for all route expect our route which already handled it, catching also cases where the system config is written via commands or yaml

@cyl3x cyl3x requested review from Bird87ZA and mstegmeyer March 19, 2025 14:38
@cyl3x cyl3x self-assigned this Mar 19, 2025
@cyl3x cyl3x merged commit aa3e8c1 into 6.6.x Mar 20, 2025
21 checks passed
@cyl3x cyl3x deleted the fix/system-config-webhook-check-66 branch March 20, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants