fix: shop is not reachable when getting 401 unauthorized response #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzKrafeld
force-pushed
the
fix-shop-is-not-reachable-when-getting-401-unauthorized-response
branch
from
83b6de3 to
79eb123
Compare
nsaliu
reviewed
Jan 17, 2025
Comment on lines
44
to
45
| if ($e instanceof HttpException && $e->getStatusCode() === Response::HTTP_UNAUTHORIZED) { | ||
| return; | ||
| } | ||
|
|
||
| if ($e instanceof HttpExceptionInterface && $e->getResponse()->getStatusCode() === Response::HTTP_UNAUTHORIZED) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hey @MoritzKrafeld, what if we only check if $e is an instance of TransportExceptionInterface ?
If it is, this means we have a "network error" and the host is not reachable.
There was a problem hiding this comment.
You're 100% right! I changed it so that we only throw the exception if the exception implements your mentioned TransportExceptionInterface 😄
MoritzKrafeld
force-pushed
the
fix-shop-is-not-reachable-when-getting-401-unauthorized-response
branch
from
79eb123 to
7b06aa6
Compare
MoritzKrafeld
requested review from
nsaliu,
fschmtt,
adrianles and
SebastianFranze
nsaliu
approved these changes
Jan 20, 2025
SebastianFranze
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started with this discussion: #56 (comment)
I tested it with multiple shops and can confirm that without these changes, some of them would not be able to pass this check as they might return 401 instead of 200. With this change, I was not able to find a shop where 401 would not pass this check.