implement fix for wrong sAddresses data issue. consider userId to get… - #2702
Open
seriewe wants to merge 3 commits into
Open
implement fix for wrong sAddresses data issue. consider userId to get…#2702seriewe wants to merge 3 commits into
seriewe wants to merge 3 commits into
Conversation
… unique order if there are multiple orders with same orderid
|
|
|
mitelg
requested changes
Jun 10, 2024
mitelg
left a comment
mitelg
left a comment
Contributor
There was a problem hiding this comment.
thanks for your contribution! some test would be nice
use injected session object
Contributor
|
hey @seriewe are you still on this one? would be nice to see some test validating your changes 🙂 |
Author
|
@mitelg I'm sorry had still not time. Does it still make sense for me to submit this in the coming weeks? |
Contributor
|
no worries, we can leave it open for now. maybe someone else would like to jump in 😊 or when you have the time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… unique order if there are multiple orders with same orderid
1. Why is this change necessary?
If multiple shops has not correctly setup the order nuber ranges and they overlap customer see billing data from other customer on /checkout/finish page.
2. What does this change do, exactly?
the change consider the userId and orderId to get the unique oder for the customer which does the checkout
3. Describe each step to reproduce the issue or behaviour.
If you have two stores with same odernumber ranges and for example Store A hast already the order 45500 and the second store now also has a new order with 45500, because of same order number ranges, the user from Store B will see the address data of user from Store A because the Method: getOrderAddress from Controller Shopware_Controllers_Frontend_Checkout just search for oder ID and does not consider Store oder User!
4. Please link to the relevant issues (if any).
5. Which documentation changes (if any) need to be made because of this PR?
6. Checklist