Skip to content

Conversation

@jhit
Copy link
Contributor

@jhit jhit commented Jul 17, 2025

Remember to run devenv update once before running devenv up!

1. Why is this change necessary?

The current devenv.nix will not work in updated Nix/devenv environment or a new install of devenv.

2. What does this change do, exactly?

It pins the Nix versions to the last version that includes NodeJS v18.

3. Describe each step to reproduce the issue or behaviour.

just checkout and run devenv up

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

  • I have written tests and verified that they fail without my change
  • I have squashed any insignificant commits
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • [x ] I have read the contribution requirements and fulfil them.

@github-actions
Copy link

github-actions bot commented Jul 17, 2025

Fails
🚫 The commit title `Merge branch '5.7' into 5.7` does not match our requirements. Please follow: www.conventionalcommits.org
Warnings
⚠️ The Pull Request doesn't contain any changes to the Upgrade file

@mitelg mitelg changed the title Fix devenv configuration for current devenv versions in 2025. fix: Update devenv configuration for current devenv versions in 2025. Jul 17, 2025
@mitelg mitelg changed the title fix: Update devenv configuration for current devenv versions in 2025. fix: Update devenv configuration for current devenv versions in 2025 Jul 17, 2025
Copy link
Contributor

@mitelg mitelg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your PR 👍
please have a look at your commit message. we are using conventional commits. adjust the message accordingly 😉

devenv.nix Outdated
{ pkgs, lib, inputs, config, ... }:

let
# Verwende eine ältere nixpkgs-Version, die noch Node 18 enthält
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not use German comments

Nodejs 18 is no longer available in the current nixpkgs repository.
Remember to run `devenv update` once before running `devenv up`!
@mitelg mitelg enabled auto-merge July 17, 2025 14:03
@mitelg mitelg disabled auto-merge July 29, 2025 11:30
@mitelg mitelg merged commit 7a2457c into shopware5:5.7 Jul 29, 2025
24 of 25 checks passed
@mitelg mitelg assigned mitelg and jhit and unassigned mitelg Jul 29, 2025
@mitelg
Copy link
Contributor

mitelg commented Jul 29, 2025

thanks for your contribution @jhit 👍🎉💙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants