shared/modtulip: Fix signature of tulip_amy_get_synth_commands for include_fx.#1032
Conversation
🔌 AMYboard PR previewEditor + flasher: https://amyboard-pr-1032.vercel.app/editor/ This preview bundles this PR's firmware — its flasher only flashes this build (not the release). Rebuilt on every push; removed when the PR closes. The hardware CI has been kicked off and should return within a few minutes, stand by! |
🌷 Tulip Web PR previewTulip Web: https://tulip-pr-1032.vercel.app/run/ Flash a Tulip to this build: on-device run Rebuilt on every push; removed when the PR closes. |
🎛️ HW CI (physical bench)AMYboard (USB-MIDI + AMY Tulip (TULIP4_R11; serial-REPL audio + WiFi screenshot): ✅ PASS — flashed this PR’s firmware; all checks matched the references. ⬇️ Artifacts: recordings · screenshot · serial logs · run logs Self-hosted bench. Audio spectral-compared to |
When we added global FX outputs to get_synth_commands, we added a second arg to Amy/Amy/init.py's get_synth_commands to specify include_fx. This didn't get propagated to the wrapper in tulip/shared/modtulip, meaning calls from Micropython to get_synth_commands always failed. This change fixes modtulip's
tulip_amy_get_synth_commandsto accept one (synth) or two (synth, include_fx) args.