Skip to content

shared/modtulip: Fix signature of tulip_amy_get_synth_commands for include_fx.#1032

Merged
bwhitman merged 1 commit into
mainfrom
fix_amy_get_synth_commands
Jun 22, 2026
Merged

shared/modtulip: Fix signature of tulip_amy_get_synth_commands for include_fx.#1032
bwhitman merged 1 commit into
mainfrom
fix_amy_get_synth_commands

Conversation

@dpwe

@dpwe dpwe commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

When we added global FX outputs to get_synth_commands, we added a second arg to Amy/Amy/init.py's get_synth_commands to specify include_fx. This didn't get propagated to the wrapper in tulip/shared/modtulip, meaning calls from Micropython to get_synth_commands always failed. This change fixes modtulip's tulip_amy_get_synth_commands to accept one (synth) or two (synth, include_fx) args.

@github-actions

Copy link
Copy Markdown

🔌 AMYboard PR preview

Editor + flasher: https://amyboard-pr-1032.vercel.app/editor/

This preview bundles this PR's firmware — its flasher only flashes this build (not the release). Rebuilt on every push; removed when the PR closes.

The hardware CI has been kicked off and should return within a few minutes, stand by!

@github-actions

Copy link
Copy Markdown

🌷 Tulip Web PR preview

Tulip Web: https://tulip-pr-1032.vercel.app/run/

Flash a Tulip to this build: on-device run tulip.upgrade(pr=1032).

Rebuilt on every push; removed when the PR closes.

@github-actions

Copy link
Copy Markdown

🎛️ HW CI (physical bench)

AMYboard (USB-MIDI + AMY zP → audio): ❌ FAIL — a check did not match, or the run errored. See the log/artifacts.

Tulip (TULIP4_R11; serial-REPL audio + WiFi screenshot): ✅ PASS — flashed this PR’s firmware; all checks matched the references.

⬇️ Artifacts: recordings · screenshot · serial logs · run logs

Self-hosted bench. Audio spectral-compared to ref/hwci_basic.wav + ref/tulip_basic.wav; Tulip screenshot pixel-compared to ref/tulip_screenshot.png. Both analog outs share one capture card, so the tests run sequentially.

@bwhitman bwhitman merged commit 34a81e0 into main Jun 22, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants