tulip/web: don't fail the build when amy has no amy.aw.js#1055
Merged
Conversation
amy dropped the separate amy.aw.js/amy.ww.js from its web build (shorepine/amy#775): emscripten >=4 inlines the AudioWorklet/WasmWorker glue into amy.js, which never references a separate .aw.js. tulip/web/build.sh still hard-copied amy/docs/amy.aw.js, so under `set -e` the whole web preview build aborts with "cp: cannot stat '../../amy/docs/amy.aw.js'" once a newer amy is pinned (e.g. the amy-pin PRs the tulipcc auto-pin workflow opens). Guard the copy with `[ -f ]` so it's copied only when an older pinned amy still ships it, mirroring amyboardweb/dev.py which already guards the same copy with os.path.exists(). No runtime effect: amy.js loads the worklet inline either way. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🌷 Tulip Web PR previewTulip Web: https://tulip-pr-1055.vercel.app/run/ Rebuilt on every push; removed when the PR closes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
amy dropped the separate
amy.aw.js/amy.ww.jsfrom its web build in shorepine/amy#775 — emscripten ≥4 inlines the AudioWorklet/WasmWorker glue directly intoamy.js, which never references a separate.aw.js.But
tulip/web/build.shstill hard-copied it:Under
set -e, once a newer amy is pinned that whole web-preview build aborts with:This is what's failing the auto-pin PRs the amy→tulipcc pin workflow opens (e.g. #1053, which pins amy#777).
Fix
Guard the copy with
[ -f ]so it's copied only when an older pinned amy still ships it — mirroringtulip/amyboardweb/dev.py, which already guards the identical copy withos.path.exists()(so AMYboard Web never broke; onlytulip/webdid).No runtime effect:
amy.jsloads the worklet inline either way, and it referencesaw.jszero times in both the old (ec78cc8) and new amy. Works for both the old amymainstill pins and the newer amy the pin PRs carry.🤖 Generated with Claude Code