amyboardweb: don't reboot the AMYboard after generating a sketch#1068
Merged
Conversation
generate_sketch_from_prompt() auto-called restart_sketch() right after loading the generated code. In control mode that sends zB1 — a full board reboot (with the "Restarting…" modal) — which the user never asked for. Just load the generated code into the editor and leave the board alone. The user hits "Write to your AMYboard" when they're ready. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
🔌 AMYboard PR previewEditor + flasher: https://amyboard-pr-1068.vercel.app/editor/ This preview bundles this PR's firmware — its flasher only flashes this build (not the release). Rebuilt on every push; removed when the PR closes. The hardware CI has been kicked off and should return within a few minutes, stand by! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the sketch generator finishes, it was auto-calling
restart_sketch()right after loading the generated code into the editor. Incontrolmode that sendszB1— a full board reboot (with the "Restarting…" modal) — which the user never asked for.Change
generate_sketch_from_prompt()now just loads the generated code into the editor and leaves the board alone. The user hits Write to your AMYboard when they're ready.🤖 Generated with Claude Code