Skip to content

SG-41239 Make type annotations compatible with py37 #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 25, 2025
Merged

SG-41239 Make type annotations compatible with py37 #427

merged 2 commits into from
Nov 25, 2025

Conversation

@carlos-villavicencio-adsk
Copy link
Contributor

@carlos-villavicencio-adsk carlos-villavicencio-adsk commented Nov 24, 2025 •
edited
Loading

  • Follow up from SG-39414 Add type annotations #422
  • Revert some type annotations compatible with Python 3.9+ because we don't want to break 3.7 yet 🫠 .
  • Added a placeholder CI job to run static type checking with mypy. For now, we skip all known issues and the idea is to start cleaning them incrementally.

@carlos-villavicencio-adsk carlos-villavicencio-adsk requested a review from a team November 24, 2025 14:46
@carlos-villavicencio-adsk carlos-villavicencio-adsk merged commit 9e35983 into master Nov 25, 2025
23 checks passed
@carlos-villavicencio-adsk carlos-villavicencio-adsk deleted the ticket/SG-41239_typing_compat_37 branch November 25, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julien-lang julien-lang julien-lang approved these changes

@eduardoChaucaGallegos eduardoChaucaGallegos eduardoChaucaGallegos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@carlos-villavicencio-adsk @julien-lang @eduardoChaucaGallegos