Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shotgun plugin manager #26

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Shotgun plugin manager #26

wants to merge 33 commits into from

Conversation

digisteph
Copy link

Hello,
I modified the code to be able to control plugins from a Shotgun entity. This is done through a plugin added in the plugins folder, as I didn't want to change things a lot in the main shotgunEventDaemon.py code. It should still work as before, actually the pluginManager plugin is loaded with the 'standard' mechanism.

The main changes are

  • Allow to run without a smtp server, which is handy when doing tests.
  • Allow plugins to read settings from the main configuration file.
  • Exposed some of the Engine functionalities to plugins and callbacks through Engine methods.
  • Tried to made sure iterating over plugins is safe, even if the list is changed.
  • Added a 'autoDiscover' setting to PluginCollection to disable automatic loading of new scripts.
  • Added some debug print to understand why some events are ignored.

Happy to contribute and hope my changes are useful !

Stéphane Deverly and others added 30 commits November 30, 2012 14:14
allow to run without an email server
9292fa7
disable smtp handler if server is not set
d9c9f6d 
added ability for plugins to access config file with their name
added some debug stuff
564762c
first proof of concept plugin using the new features from the loop
cf08499
added loadPlugin method
4cf6093
need to retrieve list of plugins from Sg
88990d2
retrieve plugins list from Shotgun
e3c4dc1
added getEngine method
b5abd09
Add getCollectionForPath method to Engine
565ae8d
added init.d file
6a10934
added autoDiscover ( on | off ) mode for plugins collection
5e67b47
added getPlugin to defer plugin loading to PluginCollection
203d671
only load plugins if they are 'Active'
38d7ebe
able to retrieve the status of the plugin and take some decision
ff0f985
can load plugin on status change
422acfb
able to unload plugins
59aecf9
moved loadPlugin onto the Engine
b7ca072
iterating over plugins in a collection is safe, even if a plugin is u…
4ca3daf 
…nloaded during iteration
try to handle other events
8e0131f
decouple attribute and entity change callbacks
6153057 
revival / retirement seems to work
still need to check script_path change CB
check if script exists before trying to load a plugin
6f0348c 
able to handle script path changes
fixed typo
58a6655 
added script check in init
added getPlugin method to the Engine
f8a99de 
added ignore_projects field to plugins
fixed bug when script path is empty
doc and removed useless lines
63376d2
added basic doc
ce3cf65
added doc
6cdf2ad
moved extra stuff in extra directory
4d742f1 
added a README to explain what the extra stuff is about
minor changes
5483a71 
added ablitiy to run shotgunEventDaemon.py on a single event
@digisteph
fixed a bug preventing plugins from being unloaded
b3df6d3 
added small utils to dump out the id file contents
use space instead of tabs
8f401dd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@digisteph