-
Notifications
You must be signed in to change notification settings - Fork 120
SG-33297 WIP #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
julien-lang
wants to merge
20
commits into
master
Choose a base branch
from
ticket/SG-33297-review-authentication-ui-flow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,208
−223
Draft
SG-33297 WIP #1032
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dc70a09
TMP DEBUG
julien-lang 517d3d6
Add cache to session data to reduce the amount of logs and file loading
julien-lang 4500beb
Improve docs and logs of get_session_data method
julien-lang 646986f
Remove duplicated log
julien-lang 1a5cf2d
Move thread wait out of the __init__
julien-lang 29f732e
No period at the end of a log line
julien-lang 8d9f9b9
Remove useless logs
julien-lang de8ad90
Cache DefaultManager host and login to prevent multiple call/logs
julien-lang 7d8d625
Set the timer interval once and for all
julien-lang a7da0e6
Fixup missing
julien-lang 42d73db
Fixup verticalLayout_2 name was used twice
julien-lang 30854fc
WIP
julien-lang 2cdd77e
Spinner step1: add file
julien-lang f113977
Spinner step2: rebuild resource file
julien-lang a2ee46b
Spinner step3: Add a label in the UI to display the spinner icon
julien-lang e41f258
WIP add spinner and raise questions
julien-lang 9c7d224
More changes and tests
julien-lang 2db4e70
eeeee
julien-lang 96fdf02
wewewerrewerw
julien-lang 6f2efcc
Loading its working after a correct domain in site field
eduardoChaucaGallegos File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,3 +22,4 @@ | |
| - ui_busy_dialog | ||
| res_files: | ||
| - resources | ||
| import_pattern: . | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -39,6 +39,8 @@ def __init__(self, fixed_host=None): | |||||||||
| self._user_settings = UserSettings() | ||||||||||
| self._system_settings = SystemSettings() | ||||||||||
| self._fixed_host = fixed_host | ||||||||||
| self._host = False # current value might be None | ||||||||||
| self._login = False # current value might be None | ||||||||||
|
Comment on lines
+42
to
+43
|
||||||||||
| self._host = False # current value might be None | |
| self._login = False # current value might be None | |
| self._host = None # current value might be None | |
| self._login = None # current value might be None |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Black would make changes.