SG-40996 prevent config autoupdate #1076
Open
+292
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et/SG-40996-prevent-config-autoupdate
…m:shotgunsoftware/tk-core into ticket/SG-40996-prevent-config-autoupdate
Contributor
carlos-villavicencio-adsk
left a comment
carlos-villavicencio-adsk
left a comment
There was a problem hiding this comment.
Made some small code style suggestions, but overall looks good. I didn't reviewed the logic because I don't fully understand the goal.
| :returns: True if current Python version is compatible, False otherwise | ||
| """ | ||
| # Get current Python version as string (e.g., "3.9.13") | ||
| current_version_str = ".".join(str(i) for i in sys.version_info[:3]) |
Contributor
There was a problem hiding this comment.
I think this can be cleaner. Not sure if this is supported by 3.9
Suggested change
| current_version_str = ".".join(str(i) for i in sys.version_info[:3]) | |
| major, minor, micro, *_ = sys.version_info | |
| current_version_str = f"{major}.{minor}.{micro}" |
Comment on lines
+262
to
+265
| log.debug( | ||
| "Local repository at %s is currently at tag %s" | ||
| % (self._path, local_tag) | ||
| ) |
Contributor
There was a problem hiding this comment.
Let's use f-strings.
| return None | ||
| except Exception as e: | ||
| log.debug( | ||
| "Could not determine local repository tag at %s: %s" % (self._path, e) |
Contributor
There was a problem hiding this comment.
Same here f-strings.
| :param latest_tag: Latest tag that was found incompatible | ||
| :param current_py_ver: Current Python version string | ||
| :param min_py_ver: Minimum Python version required by latest_tag | ||
| :returns: local_tag if compatible, None otherwise |
Contributor
There was a problem hiding this comment.
Let's add types on the docstring. Or maybe starts using type annotations in the method signature?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust Python version compatibility checks for bundle auto-updates and tag selection in the descriptor system, focusing on git tag descriptors. It ensures that the latest available bundle version is compatible with the running Python interpreter, and gracefully falls back to the highest compatible local or cached version when necessary. The changes also improve error handling and logging for version parsing and compatibility checks.
Python version compatibility enforcement:
_check_minimum_python_versiontobase.pyto verify if the current Python version meets the minimum required version specified in the bundle manifest. This is now used throughout the descriptor logic.git_tag.py, the_get_latest_versionmethod now checks if the latest tag is compatible with the current Python version, and if not, attempts to find the highest compatible version from the local repository or bundle cache, logging warnings when auto-update is blocked.Local and cached version fallback logic:
_get_local_repository_tag,_check_local_tag_compatibility, and_find_compatible_cached_versioningit_tag.pyto support falling back to a compatible local tag or cached version if the latest tag is incompatible.Error handling and logging improvements:
_find_latest_tag_by_patterninbase.pyto skip malformed version tags and log debug messages.General codebase cleanup:
base.pyandgit_tag.py. [1] [2]dict_from_uri.These changes collectively ensure that bundle updates are safe and compatible with the user's Python environment, preventing runtime errors due to version mismatches and providing clear feedback when auto-updates are blocked.