Convert specified nodes #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vert_from_write_nodes methods to allow for specific nodes to be converted rather than all
houndci-bot
reviewed
Jun 10, 2019
| # skip knobs we don't want to copy: | ||
| if knob_name in ["file_type", "file", "proxy", "beforeRender", "afterRender", | ||
| "name", "xpos", "ypos", "disable", "tile_color", "postage_stamp", | ||
| "label"]: |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| for knob_name, knob in wn.knobs().iteritems(): | ||
| # skip knobs we don't want to copy: | ||
| if knob_name in ["file_type", "file", "proxy", "beforeRender", "afterRender", | ||
| "name", "xpos", "ypos", "disable", "tile_color", "postage_stamp", |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| or not render_template_knob | ||
| or not publish_template_knob | ||
| or not proxy_render_template_knob | ||
| or not proxy_publish_template_knob): |
There was a problem hiding this comment.
line break before binary operator
visually indented line with same indent as next logical line
| or not use_name_as_output_knob | ||
| or not render_template_knob | ||
| or not publish_template_knob | ||
| or not proxy_render_template_knob |
| or not output_knob | ||
| or not use_name_as_output_knob | ||
| or not render_template_knob | ||
| or not publish_template_knob |
| write_nodes = nuke.allNodes(group=nuke.root(), filter="Write", recurseGroups = True) | ||
|
|
||
| if nodes: | ||
| # filter list to only write nodes: |
There was a problem hiding this comment.
indentation is not a multiple of four (comment)
| for knob_name, knob in int_wn.knobs().iteritems(): | ||
| # skip knobs we don't want to copy: | ||
| if knob_name in ["file_type", "file", "proxy", "beforeRender", "afterRender", | ||
| "name", "xpos", "ypos"]: |
There was a problem hiding this comment.
continuation line under-indented for visual indent
| convert_to_write_nodes_action = lambda :self.convert_to_write_nodes(show_warning=True) | ||
| convert_from_write_nodes_action = lambda: self.convert_from_write_nodes(show_warning=True) | ||
| def convert_to_write_nodes_action(): return self.convert_to_write_nodes(show_warning=True) | ||
| def convert_from_write_nodes_action(): return self.convert_from_write_nodes(show_warning=True) |
There was a problem hiding this comment.
expected 1 blank line before a nested definition, found 0
multiple statements on one line (def)
|
|
||
| convert_to_write_nodes_action = lambda :self.convert_to_write_nodes(show_warning=True) | ||
| convert_from_write_nodes_action = lambda: self.convert_from_write_nodes(show_warning=True) | ||
| def convert_to_write_nodes_action(): return self.convert_to_write_nodes(show_warning=True) |
There was a problem hiding this comment.
multiple statements on one line (def)
| for profile_name in self.__write_node_handler.profile_names: | ||
| # add to toolbar menu | ||
| cb_fn = lambda pn=profile_name: self.__write_node_handler.create_new_node(pn) | ||
| def cb_fn(pn=profile_name): return self.__write_node_handler.create_new_node(pn) |
There was a problem hiding this comment.
multiple statements on one line (def)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Implements an option to pass a list of nodes to app methods
convert_to_write_nodes()andconvert_from_write_nodes()to allow for conversion of only specified nodes rather than all nodes. Methods havenodeskeyword argument which requires a list. If this argument is not supplied, methods work as usual - converting all nodes in the script. This keeps backward compatibility.For the handler, I've decoupled conversion logic from the methods for easier maintenance.