Skip to content

Conversation

@julien-lang
Copy link
Member

This pull request refactors the tk_build_qt_resources module to improve the handling of compiler arguments and environment variables. The most important changes include switching from string-based command construction to list-based argument handling for subprocess calls, updating environment variable defaults, and refining paths for PySide2 tools.

Refactoring compiler argument handling:

Environment variable updates:

Refinement of PySide2 tool paths:

@julien-lang julien-lang requested a review from Copilot June 20, 2025 20:18
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the tk_build_qt_resources module to improve handling of compiler arguments and environment variables while refining tool paths for PySide2.

  • Switches from string‐based to list-based argument handling for subprocess calls
  • Updates the default environment variable to prioritize PYENV_VIRTUAL_ENV or VIRTUAL_ENV
  • Modifies PySide2 tool paths to include the bin directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants