Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
ff9d0d3 to
fdec21a
Compare
There was a problem hiding this comment.
Pull request overview
Updates several Rust dependencies (notably rand, rdkafka, and metrics-exporter-prometheus) and adjusts the codebase/tests to accommodate API/behavior changes, including removing a deprecated metric that now renders poorly in Prometheus output.
Changes:
- Bump deps:
rand(workspace),rdkafka(test-helpers),metrics-exporter-prometheus(shotover),lz4_flex(shotover), plus Cassandra-related deps in the workspace. - Update code to match new APIs (e.g.,
rand::RngExt,rdkafkadelivery status struct fields). - Remove deprecated
shotover_chain_messages_per_batch_countmetric and update observability integration test expectations.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test-helpers/src/connection/kafka/cpp.rs |
Adjusts rdkafka delivery status access from tuple to struct fields. |
test-helpers/Cargo.toml |
Bumps rdkafka dependency version. |
shotover/src/transforms/kafka/sink_cluster/shotover_node.rs |
Updates rand trait import to RngExt. |
shotover/src/transforms/chain.rs |
Removes deprecated metric emission. |
shotover/Cargo.toml |
Updates dependencies (incl. metrics-exporter-prometheus, lz4_flex) and changes rand dependency spec. |
shotover-proxy/tests/valkey_int_tests/basic_driver_tests.rs |
Updates rand imports to new trait naming. |
shotover-proxy/tests/runner/observability_int_tests.rs |
Removes expectations for the deleted deprecated metric. |
shotover-proxy/tests/cassandra_int_tests/routing.rs |
Updates rand imports to new trait naming. |
shotover-proxy/tests/cassandra_int_tests/batch_statements.rs |
Updates rand import to RngExt. |
changelog.md |
Adds 0.8.0 changelog entries for metric and transform removals. |
Cargo.toml |
Bumps workspace deps (cdrs-tokio, cassandra-protocol, rand). |
Cargo.lock |
Lockfile updates reflecting dependency bumps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
More updates:
thread_rngfeature for the version of rand that we use, so we need to set that feature ourselves_count_countnaming.