Skip to content

Update more deps#1982

Merged
rukai merged 1 commit intoshotover:mainfrom
rukai:update-more-deps
Mar 4, 2026
Merged

Update more deps#1982
rukai merged 1 commit intoshotover:mainfrom
rukai:update-more-deps

Conversation

@rukai
Copy link
Copy Markdown
Contributor

@rukai rukai commented Mar 2, 2026

More updates:

  • rand, provides random number generation
    • the Rng crate was renamed to RngExt
    • thread_rng feature is now required, technically this was always required, but another one of our dependencies was pulling in the feature, so we didnt need to do it ourselves. Since we are now on rand 0.10, and that dependency is still using 0.9, it is no longer pulling in thread_rng feature for the version of rand that we use, so we need to set that feature ourselves
  • rdkafka, delivery status is now stored as a struct instead of a tuple - nice!
  • metrics-exporter-prometheus, it now processes the name of one of our metrics differently to avoid the double _count_count naming.
    • the only metric affected by this is deprecated, so rather than rename it I've removed the metric entirely.

@rukai rukai force-pushed the update-more-deps branch from 3270bca to 2742598 Compare March 2, 2026 21:57
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 2, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing rukai:update-more-deps (45d1b8b) with main (37cdad6)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@rukai rukai force-pushed the update-more-deps branch 2 times, most recently from ff9d0d3 to fdec21a Compare March 2, 2026 23:43
@rukai rukai marked this pull request as ready for review March 3, 2026 00:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates several Rust dependencies (notably rand, rdkafka, and metrics-exporter-prometheus) and adjusts the codebase/tests to accommodate API/behavior changes, including removing a deprecated metric that now renders poorly in Prometheus output.

Changes:

  • Bump deps: rand (workspace), rdkafka (test-helpers), metrics-exporter-prometheus (shotover), lz4_flex (shotover), plus Cassandra-related deps in the workspace.
  • Update code to match new APIs (e.g., rand::RngExt, rdkafka delivery status struct fields).
  • Remove deprecated shotover_chain_messages_per_batch_count metric and update observability integration test expectations.

Reviewed changes

Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
test-helpers/src/connection/kafka/cpp.rs Adjusts rdkafka delivery status access from tuple to struct fields.
test-helpers/Cargo.toml Bumps rdkafka dependency version.
shotover/src/transforms/kafka/sink_cluster/shotover_node.rs Updates rand trait import to RngExt.
shotover/src/transforms/chain.rs Removes deprecated metric emission.
shotover/Cargo.toml Updates dependencies (incl. metrics-exporter-prometheus, lz4_flex) and changes rand dependency spec.
shotover-proxy/tests/valkey_int_tests/basic_driver_tests.rs Updates rand imports to new trait naming.
shotover-proxy/tests/runner/observability_int_tests.rs Removes expectations for the deleted deprecated metric.
shotover-proxy/tests/cassandra_int_tests/routing.rs Updates rand imports to new trait naming.
shotover-proxy/tests/cassandra_int_tests/batch_statements.rs Updates rand import to RngExt.
changelog.md Adds 0.8.0 changelog entries for metric and transform removals.
Cargo.toml Bumps workspace deps (cdrs-tokio, cassandra-protocol, rand).
Cargo.lock Lockfile updates reflecting dependency bumps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rukai rukai force-pushed the update-more-deps branch from bbc4f15 to 22babfd Compare March 4, 2026 22:55
@rukai rukai force-pushed the update-more-deps branch from 22babfd to 45d1b8b Compare March 4, 2026 22:56
@rukai rukai enabled auto-merge (squash) March 4, 2026 22:56
@rukai rukai merged commit 34a310d into shotover:main Mar 4, 2026
70 of 74 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants