Skip to content

Remove websocket support#1983

Merged
rukai merged 2 commits intoshotover:mainfrom
rukai:remove-ws-support
Mar 4, 2026
Merged

Remove websocket support#1983
rukai merged 2 commits intoshotover:mainfrom
rukai:remove-ws-support

Conversation

@rukai
Copy link
Copy Markdown
Contributor

@rukai rukai commented Mar 3, 2026

websocket support for shotover is a really cool idea, enabling some unique tooling, such as querying cassandra directly from a webbrowser, with just shotover in between.

Unfortunately given that:

  • websocket support is non-standard to any of the protocols in shotover
  • I'm not aware of anyone attempting to use it
  • it adds a lot of extra code and dependencies to the project, increasing maintenance burden

I am proposing to delete it.
If we ever decide we want it back, it can easily be restored from the previous commit.

@rukai rukai force-pushed the remove-ws-support branch from 7213ada to ff0b1c0 Compare March 3, 2026 00:18
@rukai rukai force-pushed the remove-ws-support branch from ff0b1c0 to ab68931 Compare March 3, 2026 00:25
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 3, 2026

Merging this PR will improve performance by 20.05%

⚡ 5 improved benchmarks
✅ 31 untouched benchmarks
⏩ 2 skipped benchmarks1

Performance Changes

Benchmark BASE HEAD Efficiency
decode_request_fetch_create 10.9 µs 9.7 µs +13.15%
decode_request_metadata_create 8.5 µs 7.1 µs +20.05%
decode_request_produce_create 10.2 µs 8.9 µs +14.19%
decode_request_metadata_drop 2.7 µs 2.4 µs +13.43%
decode_request_list_offsets_create 10.7 µs 9.4 µs +14.16%

Comparing rukai:remove-ws-support (b822378) with main (15a58b0)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e650ae3) during the generation of this report, so 15a58b0 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@rukai rukai marked this pull request as ready for review March 3, 2026 00:40
@rukai rukai merged commit 37cdad6 into shotover:main Mar 4, 2026
133 of 138 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants