Added parent closed check to utility window workaround

[LenczuVex]

• Added parent closed check to utility window workaround
• This is fix proposal for File picker instantly closes #429

[shpaass]

Rebased on fresh master.

[shpaass]

Asking just in case,
@LenczuVex, have you tested that the Welcome Screen, File Selector, and About windows work as intended?

[LenczuVex]

I have rechecked that and this behaviour can be not actually intended one. My WM automatically focused the window so when I clicked away code worked, window stayed during welcome screen, and everything seamed good, but as I retested I realized that on most systems you would have to actually first focus on the window after closing for example welcome and then unclick that. I'll try to find better solution.

[LenczuVex]

I have found new solution that maybe can work as permanent one, tested on Linux and Windows 11.

[DaleStan]

I'd prefer to have the parent window send the focus back to the child window, if that's possible. Otherwise, this looks good to me.

[shpaass]

Thank you and welcome to Yafc!

[LenczuVex]

Thanks for warm welcome. ❤️

I can add the focus functionality in other pull request, I am currently dealing with some university stuff and don't have time to do new behaviour. I should be able to resolve it until Friday, so if you prefer to make this change here then I'll probably do it over the weekend. I think it's better to make seperate pull request for it, because it's something slightly different.

Also I forgot to run environment setup script and there are in fact missing braces in if statement, bit I can resolve it this weekend earliest, with the other feature, so it might be easier if you fix it depending on your availability.

[shpaass]

Take your time, there's no rush.

[shpaass]

Removing the approval for now so I don't miss the changes.

[DaleStan]

I saw another comment about this in Discord, so I resolved the conflict and adjusted the PR to reactivate the child.

[veger]

You might need to add a changelog entry so others are notified the issue should be fixed

[shpaass]

You might need to add a changelog entry so others are notified the issue should be fixed

I can do the changelog part, no worries.

The reason why this PR has not been merged yet is that I am concerned about the UI-architecture point that @DaleStan mentioned. In other words, I need to understand the severity of the pointed-out issue. The main thing that we want to prevent is for the UI architecture to get even more convoluted.

[shpaass]

I'd prefer to have the parent window send the focus back to the child window

Could you please specify what part of the patch is related to that suggestion?
The only way I managed to interpret it is that there was a mixup in the suggestion, and it was about that the child window should give the focus back to the parent on being closed. But I am not sure.

[shpaass]

@DaleStan ^, forgot to ping you in the previous message.

[veger]

I understood that Dale's additional commit (Re-activate the child window if the parent gains focus) addressed his concern. But let's wait on confirmation

[shpaass]

Good catch, you're right. Apologies for the confusion.

[shpaass]

Then I'll squash the commits and add a changelog entry before the merge.

[shpaass]

@DaleStan, please check if I interpreted the implementation correctly in the commit message. Feel free to change it if necessary.

[DaleStan]

Looks good to me