Skip to content

Conversation

@DaleStan
Copy link
Collaborator

Part 1 of (hopefully) 2 for internationalizing Yafc. Primarily, this downloads an appropriate Noto Sans font for languages Roboto doesn't support, and then restarts to switch to that font.

@DaleStan DaleStan requested a review from veger April 29, 2025 02:22
@DaleStan DaleStan requested a review from shpaass as a code owner April 29, 2025 02:22
@DaleStan
Copy link
Collaborator Author

@veger, I believe you use Linux. Will you double-check that the restart code works properly on Linux, please?

Copy link
Owner

@shpaass shpaass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature!

@veger
Copy link
Collaborator

veger commented Apr 29, 2025

Yes I am using Linux, but I am away for a week. So I cannot test at the moment

@DaleStan DaleStan force-pushed the internationalization-part-1 branch from d57d46d to dde7a32 Compare May 4, 2025 00:27
Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried switching to Japanese and Chinese languages and both times downloaded their required font got downloaded and afterwards YAFC restarted.

So restarting YAFC seem to be working on Linux as well.

@shpaass shpaass merged commit 307a2bc into shpaass:master May 5, 2025
1 check passed
@DaleStan DaleStan deleted the internationalization-part-1 branch May 5, 2025 19:24
@shpaass shpaass changed the title Internationalization part 1 Internationalization (i18n) part 1 Oct 17, 2025
@shpaass
Copy link
Owner

shpaass commented Oct 17, 2025

@DaleStan, for posterity, could you please provide the context of what problem your localization PRs (#467, #475) were solving?

@DaleStan
Copy link
Collaborator Author

The problem was that it wasn't reasonably possible to localize Yafc. Someone who wanted Yafc in Chinese would have to download the source, figure out which strings needed to be translated, translate them, and recompile it.

Now, they can just translate yafc.cfg instead.

A secondary benefit is that texts like "Require ANY of these Researches" correctly pluralize "Researches", which used to be misspelled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants