-
Notifications
You must be signed in to change notification settings - Fork 34
Internationalization (i18n) part 1 #467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@veger, I believe you use Linux. Will you double-check that the restart code works properly on Linux, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feature!
|
Yes I am using Linux, but I am away for a week. So I cannot test at the moment |
Update language documentation.
d57d46d to
dde7a32
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried switching to Japanese and Chinese languages and both times downloaded their required font got downloaded and afterwards YAFC restarted.
So restarting YAFC seem to be working on Linux as well.
|
The problem was that it wasn't reasonably possible to localize Yafc. Someone who wanted Yafc in Chinese would have to download the source, figure out which strings needed to be translated, translate them, and recompile it. Now, they can just translate yafc.cfg instead. A secondary benefit is that texts like "Require ANY of these Researches" correctly pluralize "Researches", which used to be misspelled. |
Part 1 of (hopefully) 2 for internationalizing Yafc. Primarily, this downloads an appropriate Noto Sans font for languages Roboto doesn't support, and then restarts to switch to that font.