-
Notifications
You must be signed in to change notification settings - Fork 34
Blueprint Improvements / Add support for exporting all building entities to one blueprint. #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to YAFC-CE, thank you for your contribution!
I am no blueprint expert (no idea how they are formatted/work), but the rest looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content of the changes looks good, but it looks to me like you changed several files from exclusively CRLF line endings to a mix of CRLF and LF line endings.
I suspect this is due to your setting for core.autocrlf; I have it set to true
I thought I had accounted for all of the line ending misshapes, I'll fix in a bit |
I advise to use rebasing in the future instead of merging. It results in a cleaner commit history. Or you can leave it as-is and I'll |
In the future, I'll rebase. Just used the GitHub interface to sync the fork and it merged instead. Not used to syncing forks. |
|
Okay, pretty sure we got the formatting/whitespace issues resolved, and I fixed/rebased everything |
|
Alright, then we wait for @DaleStan review, then either me or you squashes the fixes into relevant commits. |
|
Hmm, DaleStan said that the content is fine. So only squashes are left to be done. Please let me know if you want me to do it. |
f721ba8 to
229fef4
Compare
Update blueprint and fix order (JsonPropertyName first, JsonIgnore second) Make exporting entities with fuel configurable Add support for exporting all building entities to one blueprint Upgrade Blueprint classes to support new logistic filter sections Fix issue when trying to export blueprint with modules Support for new burner fuel inventory Blueprints will now be exported with burner fuel inventory set
|
Squashed the fix and added a commit subject. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feature, and welcome to the team!
Upgrade Blueprint classes to support new logistic filter sections
Fix issue when trying to export blueprint with modules. closes #471
Support for new burner fuel inventory
Blueprints will now be exported with burner fuel inventory set (Default enabled, but can be disabled in preferences)