fix(#478): ./build.sh works from clean source again. #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uhm... I do..! 😛 But I will manage! |
veger
approved these changes
May 19, 2025
shpaass
added a commit
that referenced
this pull request
Aug 27, 2025
#486 broke (or, maybe 'failed to fix') `dotnet build Yafc` and `dotnet run --project Yafc` on clean source or after adding new i18n keys. This fixes those commands again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #478, at least for ./build.sh. Attempts to use
dotnet run --project Yafcfrom clean source are still broken, but it doesn't appear anyone is trying to do that.Other solutions I tried all seemed to have more pain than benefits:
dotnet build FactorioCalc.sln --target:Yafc:Publish -r win-x64would try to run an explicitly x64 version of I18n.Generate on arm64 processors, or vice versa. Using project-level dependencies requires a #if to prevent introducing a warning, and adds extra files to the publish folders.