Skip to content

491: PyAL: some recipes show no icon #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 8, 2025
Merged

491: PyAL: some recipes show no icon #497

merged 3 commits into from
Jul 8, 2025

Conversation

@DaleStan
Copy link
Collaborator

@DaleStan DaleStan commented Jul 8, 2025

This fixes #491, along with the incorrect overlay offsets.

@DaleStan DaleStan requested a review from veger July 8, 2025 06:14
@DaleStan DaleStan requested a review from shpaass as a code owner July 8, 2025 06:14
shpaass
shpaass approved these changes Jul 8, 2025
View reviewed changes
Copy link
Owner

@shpaass shpaass left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Glad to see you're back.

veger
veger approved these changes Jul 8, 2025
View reviewed changes
Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed fixes the rending of icons with the (number) overlay.

@shpaass shpaass merged commit f830cff into shpaass:master Jul 8, 2025
1 check passed
@DaleStan DaleStan deleted the 491-pyal-some-recipes-show-no-icon branch July 9, 2025 02:31
@DaleStan DaleStan mentioned this pull request Sep 16, 2025
Merged
shpaass added a commit that referenced this pull request Sep 16, 2025
@shpaass
Fix icons (again) (#525)
9f6c4c4 
Another attempt at #497, this time fixing technology icons.

![Untitled](https://github.com/user-attachments/assets/a32c795f-1218-442c-8f9e-359e3b844392)
I attempted to dump all the icons and compare their hashes, but the
slight changes caused by (I assume) blitting before downscaling made
that futile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@veger veger veger approved these changes

@shpaass shpaass shpaass approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[pY:AL] Some recipes show no icon

3 participants

@DaleStan @veger @shpaass