Skip to content

Conversation

@ApocDev
Copy link

@ApocDev ApocDev commented Aug 4, 2025

This pull request adds a new feature that allows users to quickly add the most cost-effective recipe for an item by holding Ctrl+Shift and clicking on it.

Note that this de-prioritizes barreling recipes by default.

@ApocDev ApocDev requested a review from shpaass as a code owner August 4, 2025 13:41
@shpaass
Copy link
Owner

shpaass commented Aug 4, 2025

Looks good to me. Thank you for the feature!
Please don't forget to add an entry to the changelog. Alternatively, you can let me know that you want me to take care of that.

@ApocDev
Copy link
Author

ApocDev commented Aug 4, 2025

Thanks! Added an entry to the changelog. (There's an empty version/date one before mine, not sure what you want to do about that?)

@shpaass
Copy link
Owner

shpaass commented Aug 4, 2025

Thanks! Added an entry to the changelog. (There's an empty version/date one before mine, not sure what you want to do about that?)

So, the way it works is that the empty-version area is the version that is yet to be released. What I want you to do is to put your entry in this unnumbered version.

Feel free to also add this comment to the very top of the file:

// If you want to add an entry to the changelog, then please add it to the section without a release date and version.
// If there is no such section, then copypaste the previous version, remove the info, and put the result below the commented section.
// Below is the format and the purpose of each field and section:

@ApocDev
Copy link
Author

ApocDev commented Aug 4, 2025

Done

@shpaass
Copy link
Owner

shpaass commented Aug 4, 2025

I can clean it up later, but just letting you know - we are totally fine with force-pushing in PRs. The only place where we don't want to force-push is the master branch.

Copy link
Collaborator

@veger veger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I guess we should add this feature to the ./Yafc/Data/Tips.txt file, so other users will be more likely to find out about this

@shpaass shpaass force-pushed the feat/add-ctrl-shift-click-best-cost-recipe branch from a830eed to d2286d1 Compare August 9, 2025 11:35
@shpaass
Copy link
Owner

shpaass commented Aug 9, 2025

Rebased on fresh master.

$ git range-diff a830eed6...d2286d13
-:  ------- > 1:  e9cd753 fix: Modify text colors for dark mode readability
-:  ------- > 2:  f3ccc8b feat: Add new icon colors to the color scheme
1:  7432005 = 3:  a1b47bd feat: Add Ctrl+Shift+Click to add best-cost recipe
2:  e487443 = 4:  e7e840f docs: Add changelog entry for best-cost recipe feature
3:  b13b236 = 5:  28f8a06 Revert "docs: Add changelog entry for best-cost recipe feature"
4:  a315e72 ! 6:  8bf2b60 docs: Add changelog entry for best-cost recipe feature
    @@ changelog.txt
     +// Below is the format and the purpose of each field and section:
      // The purpose of the changelog is to provide a concise overview of what was changed.
      // The purpose of the changelog format is to make it more organized.
    - // Versioning follows the x.y.z pattern. Since 0.8.0, the increment has the following meaning:
    + // If you want to add an entry to the changelog, then please add it to the section without a release date and version.
     @@
      ----------------------------------------------------------------------------------------------------------------------
      Version:
5:  a830eed = 7:  d2286d1 docs: Update changelog and tips for Ctrl+Shift+Click feature

@shpaass shpaass force-pushed the feat/add-ctrl-shift-click-best-cost-recipe branch from d2286d1 to 2d206b2 Compare August 9, 2025 11:59
@shpaass
Copy link
Owner

shpaass commented Aug 9, 2025

Squashed fixes and made some cosmetic changes.

@shpaass shpaass merged commit 6ec4276 into shpaass:master Aug 9, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants