chore: Add script to rebuild linux/liblua52.so #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpaass
approved these changes
Aug 13, 2025
DaleStan
approved these changes
Aug 14, 2025
Note that liblua.so.patch is taken from Arch Linux package source.
|
Rebased on fresh master. |
shpaass
added a commit
that referenced
this pull request
Aug 25, 2025
Related to #515, liblua52.so can be built using the system CFLAGS variable. I noticed when building/modifying the AUR package that running the build script only included `-fPIC`, and built using only `-O2 -Wall -DLUA_COMPAT_ALL -DLUA_USE_LINUX -fPIC`. This didn't compile using the debug options set by makepkg. Adding `${CFLAGS}` to MYCFLAGS in the build script allowed the library to compile with those symbols, as well as other security mitigations. SYSCFLAGS is set explicitly in Lua's Makefile, so it's safer to change MYCFLAGS and MYLDFLAGS instead without patching.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #506 we have (in theory) no idea what liblua52.so contains, and even worse there is no way to reproduce this binary blob to check if we ship/release the expected one.
So this PR adds a
build-linux.shscript that downloads and rebuilds the liblua52.so.In order to know for sure the correct archive is downloaded it checks the sha256 as provided by the Lua project (https://www.lua.org/ftp/). So with this, the whole chain is traceable from source to the binary blob in the commit I guess (I am not an expert on this).
Besides this, it is now much easier to recompile with debug symbols included, which might be needed to fixgure out what is going on with #506.
The recompiled liblua52.so is included in this PR and is tested with a pyanodon save file, which still loads fine.
Finally, I also removed the liblua52.a, it is available after running
build-linux.sh, but it is not used by Yafc.Note that I only made the Linux script and changes, as I do not have a Mac or experience with it. But if someone is willing we can add an OS X script and update the OS X binaries as well.