Skip to content

Fix display tab "New page" on fresh project #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix display tab "New page" on fresh project #530

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63b7078
Fix display tab "New page" on fresh project
kubiix Sep 23, 2025
df715e6
Fix display tab "New page" on fresh project (changelog)
kubiix Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Yafc.Model/Model/Project.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,16 @@ public override ModelObject? ownerObject {
internal set => throw new NotSupportedException();
}

public void AssureFirstPage() {
if (pages.Count == 0) {
ProjectPage firstPage = new ProjectPage(this, typeof(ProductionTable));
pages.Add(firstPage);
pagesByGuid[firstPage.guid] = firstPage;

displayPages.Add(firstPage.guid);
}
}

private void UpdatePageMapping() {
hiddenPages = 0;
pagesByGuid.Clear();
Expand Down
10 changes: 1 addition & 9 deletions Yafc/Windows/MainScreen.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,15 +79,7 @@ private void SetProject(Project project) {
this.project = project;
if (project.justCreated) {
_ = ShowPseudoScreen(new MilestonesPanel());
}

if (project.pages.Count == 0) {
ProjectPage firstPage = new ProjectPage(project, typeof(ProductionTable));
project.pages.Add(firstPage);
}

if (project.displayPages.Count == 0) {
project.displayPages.Add(project.pages[0].guid);
project.AssureFirstPage();
}

// Hack to activate all page solvers for the summary view
Expand Down
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ Date:
Fixes:
- Fix rendering of multi-icon technologies (e.g. shooting speed techs)
- Add simplified support for debug.getinfo(), only returns short_src. Fixes #455, #504.
- Fix initial New Page was not displayed in tab bar after creating new project.
----------------------------------------------------------------------------------------------------------------------
Version: 2.15.0
Date: September 1st 2025
Expand Down