Add missing fs-extra build dependency#440
Open
reikjarloekl wants to merge 1 commit into
Open
Conversation
post-build.cjs requires 'fs-extra' and relies on APIs that native fs does not provide (copySync, moveSync, emptyDirSync, writeJsonSync), but the package was not declared in package.json. On a clean install the post-build step of every extension/app build fails with "Cannot find module 'fs-extra'". Add fs-extra to devDependencies so the build works from a fresh clone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
post-build.cjs(run as thepostbuild*step of every extension/app/web build) does:and uses APIs that Node's native
fsdoes not provide —copySync,moveSync,emptyDirSync,writeJsonSync. Howeverfs-extrais not declared anywhere inpackage.json.On a clean checkout,
pnpm install && pnpm buildfails during post-build with:(It only appears to work in environments where
fs-extrahappens to be hoisted/available from another source.)Fix
Declare
fs-extraindevDependenciesso the build post-processing works from a fresh clone.