add support for headers #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Oh looks like someone else also did a PR for headers #1 did see that when I did my work. Not sure which solution you'd like more. |
Owner
|
Hello, thanks for your PR! I need to fix my home computer first, before I can take a look at/try this. I expect to have the time for that in mid-September. Will get back to you after that. |
Author
|
This library has been super useful to me, thanks for putting it out there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed headers for this to work for my use case, after looking into the documentation in grpcurl, it looks liked headers were supported, so I extended
ob-grpcto also support headers. I tried to follow the existing patterns and add some documentation. Let me know if you'd like me to re-format the README in a different way.