Draft: feature/BQ-250 into [email protected] 🌊 added organizations activities table with add activity modal #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c in schedule component
…eview workingHours
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vitrivdolkom
requested changes
Apr 7, 2024
| <AcivityListCombobox | ||
| value={field.value} | ||
| className='w-full' | ||
| onSelect={(newValue) => form.setValue('activity', newValue ?? '')} |
There was a problem hiding this comment.
а зачем тут проверка ?? '' или это типизация такая?
There was a problem hiding this comment.
Вообще, типизация такая
| '3': { time: { from: '09:00', to: '18:00' }, dayOff: false }, | ||
| '4': { time: { from: '09:00', to: '18:00' }, dayOff: false }, | ||
| '5': { time: { from: '09:00', to: '18:00' }, dayOff: false }, | ||
| '6': { time: { from: '09:00', to: '18:00' }, dayOff: true } |
There was a problem hiding this comment.
вынести вне компонента в константу
Comment on lines
32
to
34
| dateRange: { | ||
| from: undefined, | ||
| to: undefined |
There was a problem hiding this comment.
а undefined точно нужно указывать? Мб просто необязательные поля можно не вставлять здесь
| const postOrganizationAddSchedule = usePostOrganizationAddScheduleMutation(); | ||
|
|
||
| const onSubmit = addScheduleForm.handleSubmit(async (values) => { | ||
| console.log(values); |
...chedule/components/AddScheduleDialog/components/AddScheduleForm/hooks/useAddScheduleForm.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
7
to
11
| export const postOrganizationAddSchedule = async ({ | ||
| params: { organizationId, ...params }, | ||
| config | ||
| }: PostOrganizationAddScheduleRequestConfig) => | ||
| api.post(`organization/${organizationId}/add-schedule`, params, config); |
There was a problem hiding this comment.
а бэк под расписание готов сейчас? Тут неверное название, postOrganizationByOrganizationIdAddSchedule ну или если на бэке просто id postOrganizationByIdAddSchedule
Если будешь менять название не забуть сменить типы выше и мутацию
debabin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.