Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/BQ-253 into [email protected] 🧊 partner pages #48

Open
wants to merge 5 commits into
base: [email protected]
Choose a base branch
from

Conversation

debabin
Copy link
Member

@debabin debabin commented Apr 10, 2024

No description provided.

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
big-quest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2024 5:11pm

@@ -26,7 +26,7 @@ const OrganizationProfileTariffPage = async ({ params }: OrganizationProfileTari
const getTariffByLegalEntityIdResponse = await getTariffByLegalEntityId({
params: { legalEntityId: params.organizationId },
config: {
cache: 'no-cache'
cache: 'no-store'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это я описался? Везде no-store вроде а я no-cache написал

Comment on lines +5 to +9
interface OrganizationPageLayoutProps {
children: React.ReactNode;
}

const PartnerLayout = async ({ children }: OrganizationPageLayoutProps) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PartnerLayoutProps

}: UseEditOrganizationTariffFormParams) => {
const router = useRouter();
const queryClient = useQueryClient();
const editOrganizationForm = useForm<EditOrganizationTariffSchema>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editOrganizationTariffForm, надо заменить в обоих местах

Comment on lines +31 to +34
const isPartner = request.url.includes(ROUTES.PARTNER.ROOT);

if (!isAuthenticated && (isOrg || isPartner)) {
console.log('@.2 !isAuthenticated && isOrg, org or partner page requires auth');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а зачем отдельно обрабатывать кесы с орг и партнером?

@@ -0,0 +1,61 @@
import { NotebookTextIcon, TrendingUpIcon, UsersRoundIcon } from 'lucide-react';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

все таки без копипасты тут никак как я понимаю

Comment on lines +14 to +17
const getOrganizationByIdResponse = await getOrganizationById({
params: { id: getOrganizationCurrentResponse.id },
config: { cache: 'no-store' }
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

бесполезный запрос, мы же в запросе выше получаем ту же инфу что и здесь. Либо неправильно типизирован запрос getOrganizationCurrent

Comment on lines +31 to +34
const getOrganizationByIdResponse = await getOrganizationById({
params: { id: getOrganizationCurrentResponse.id },
config: { cache: 'no-store' }
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

бесполезный запрос, мы же в запросе выше получаем ту же инфу что и здесь. Либо неправильно типизирован запрос getOrganizationCurrent

@@ -24,8 +31,8 @@ export const getUserMeConfig: RestRequestConfig = {
},
{
entities: {
query: {
email: '[email protected]'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а как мы до этого квери передовали? Надо убрать тогда теперь это прокидывание кверей

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants