Add 3-2-1 countdown before recording starts#458
Closed
theabhipareek wants to merge 2 commits intosiddharthvaddem:mainfrom
Closed
Add 3-2-1 countdown before recording starts#458theabhipareek wants to merge 2 commits intosiddharthvaddem:mainfrom
theabhipareek wants to merge 2 commits intosiddharthvaddem:mainfrom
Conversation
…before-recording Add 3-2-1 countdown before recording starts
Owner
|
please add videos in your prs 🙏 |
Owner
|
also why does it say 0 changes lmao |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request: 3-2-1 Countdown Before Recording Starts
Description
This PR implements a 3-2-1 countdown timer that displays when users press the Record button. The actual recording begins only after the countdown completes, giving users time to prepare before capture starts.
Motivation
Problem: Users could accidentally record setup actions because capture started immediately when pressing Record.
Solution: A visible countdown provides a pre-roll buffer, allowing users to:
Related Issue: #453 - Add 3-2-1 countdown before recording starts
Type of Change
Related Issue(s)
Resolves: siddharthvaddem/openscreen#453
Technical Changes
1. useScreenRecorder Hook (
src/hooks/useScreenRecorder.ts)countdownSeconds: number- tracks current countdown value (3, 2, 1, 0)isCountingDown: boolean- flag to display countdown UIstartCountdown()function:startRecording()after countdown completestoggleRecording()againtoggleRecording():startCountdown()instead of directly callingstartRecording()2. LaunchWindow Component (
src/components/launch/LaunchWindow.tsx)bg-black/70)text-red-500)isCountingDown === true3. User Flow
Screenshots / Video
Countdown States:
Testing
Manual Testing Steps:
Start Countdown
Countdown Progression
Cancel Countdown
Recording Controls After Countdown
Edge Cases
Build Validation:
Checklist
Additional Notes
Benefits:
Future Enhancements (Optional):