docs: added job that uses configmap with helm values to install cilium #71
+107
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basbremer
changed the title
Iheanacho-ai
approved these changes
Oct 29, 2025
|
@smira what do you think of the code quality of this PR, do you think its good to merge? |
smira
reviewed
Nov 5, 2025
There was a problem hiding this comment.
I don't like any of the ways except for the official Cilium CLI way. I think we should stop even publishing this and link to Cilium docs.
These Kubernetes jobs are all hacks which I don't want to support in any way. Of course people are free to use whatever way they feel works great, but it shouldn't be the way we recommend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation provides an option to create a Kubernetes Job that handles the installation of Cilium.
Unfortunately, you need to provide all configuration options directly within this Job as arguments.
What changed?
This PR enhances the documentation by introducing a Job that allows you to provide the Cilium Helm values separately.
The Helm values are supplied via a ConfigMap and mounted as a file in the Job.
Why it's needed?
In my opinion, this gives better visibility of the desired configuration options for Cilium, especially when you have many of them.
Screenshot
The part shown in the image below is added to the existing Cilium docs: