fix: vulnerability scans with extensions#473
Merged
talos-bot merged 1 commit intoJun 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the enterprise SPDX bundle merge logic so the merged document has a single, stable “DOCUMENT-DESCRIBES” root package (with all per-source roots referenced beneath it), improving grype’s ability to match OpenVEX suppressions when extensions are included.
Changes:
- Add an explicit synthetic root package (
DocumentRoot-Directory-talos) to the merged SPDX document and ensure the document describes only that root. - Rewrite per-source
DOCUMENT DESCRIBES <root>relationships intoCONTAINSrelationships under the synthetic root during merge. - Introduce
TalosPackageName(enterprise build) and add a regression test asserting the single-root invariants.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| pkg/constants/name_ent_on.go | Introduces TalosPackageName and derives TalosPURL from it for consistent naming. |
| enterprise/spdx/builder/spdx.go | Adds a synthetic root package and re-parents per-source roots under it to preserve a single DOCUMENT-DESCRIBES root. |
| enterprise/spdx/builder/spdx_test.go | Adds a regression test ensuring a single described root and correct root metadata for syft/grype matching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
When adding extensions grype was unable to match the suppressions due to the way we were generating sboms. So let's add a root identifier and put all others as a reference. Signed-off-by: Noel Georgi <git@frezbo.dev>
frezbo
force-pushed
the
fix/vulnerability-scans-with-extensions
branch
from
6a96a3e to
b5d3d92
Compare
shanduur
approved these changes
Jun 1, 2026
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When adding extensions grype was unable to match the suppressions due to the way we were generating sboms. So let's add a root identifier and put all others as a reference.