feat: generate coverage for the integration tests#527
Merged
talos-bot merged 1 commit intoJun 10, 2025
Conversation
Unix4ever
force-pushed
the
generate-coverage-integration-tests
branch
from
700f5e5 to
37c4809
Compare
smira
approved these changes
Jun 9, 2025
| for _, spec := range integrationTests.Tests { | ||
| build := golang.NewBuild(builder.meta, spec.Name, spec.Path, "go test -c -covermode=atomic") | ||
| build := golang.NewBuild(builder.meta, spec.Name, spec.Path, | ||
| fmt.Sprintf( |
Member
There was a problem hiding this comment.
it'd be nice to merge the output coverage of this step, and unit-tests step, and push the combined to gocov codecov step for visualization
Member
Author
There was a problem hiding this comment.
Is it merged by putting everything into a single long coverage.txt?
Member
There was a problem hiding this comment.
I don't know, but I would assume it can pick up multiple files and merge them itself - but you need to experiment
Member
Author
There was a problem hiding this comment.
I think I've figured it out
Use all canonical module paths to generate `coverpkg`. Signed-off-by: Artem Chernyshev <artem.chernyshev@talos-systems.com>
Unix4ever
force-pushed
the
generate-coverage-integration-tests
branch
from
37c4809 to
5128bc1
Compare
smira
approved these changes
Jun 9, 2025
Member
Author
|
/m |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use all canonical module paths to generate
coverpkg.