chore: bump Go and deps#623
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s Go toolchain and a set of pinned dependencies (Go modules, Docker/CI tooling, and GitHub Actions), and regenerates the derived config/artifacts produced by kres.
Changes:
- Bump Go/tooling versions (Go 1.26.0 → 1.26.1, golangci-lint, markdownlint-cli, and various action pins).
- Update Go module dependencies (
go.mod/go.sum) and align generated build artifacts (Makefile,Dockerfile, generated workflows/configs). - Regenerate Helm chart docs/metadata for the test chart.
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
test/test-helm-chart/README.md |
Regenerated helm-docs output; appVersion badge changed. |
test/test-helm-chart/Chart.yaml |
Chart metadata updated (notably appVersion). |
internal/output/golangci/golangci.yml |
Golangci-lint output template updated (staticcheck settings removed). |
internal/output/ghworkflow/gh_workflow_test.go |
Updated expected pinned commit for setup-buildx action in tests. |
internal/config/constants.go |
Bumped pinned versions/refs for actions and tooling (Go, golangci-lint, etc.). |
go.mod |
Go version and module dependency bumps. |
go.sum |
Checksums updated for bumped modules. |
Makefile |
Regenerated with updated tool versions (Go, golangci-lint). |
Dockerfile |
Regenerated; updated dockerfile frontend and markdownlint-cli version. |
.golangci.yml |
Regenerated golangci-lint config (staticcheck settings removed). |
.github/workflows/helm.yaml |
Regenerated workflow with updated action pins. |
.github/workflows/ci.yaml |
Regenerated workflow with updated action pins. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "1.0.0" | ||
| appVersion: "undefined" |
There was a problem hiding this comment.
appVersion is set to the literal string "undefined". Since the helm GitHub workflow packages/releases this chart on tags without running make generate (which would rewrite appVersion), this value would ship in released chart metadata. Please set appVersion to a real version (or omit the field) and ensure the release process updates it deterministically (e.g., from the tag) before packaging.
| appVersion: "undefined" |
Bump all deps, self-rekres. Signed-off-by: Utku Ozdemir <utku.ozdemir@siderolabs.com>
utkuozdemir
force-pushed
the
chore/bump-deps
branch
from
c09f867 to
3328d87
Compare
| fi`, helm.meta.HelmChartDir, *helm.meta.ChartVersionMajor)) | ||
| } else { | ||
| generateTarget.Script(fmt.Sprintf(`@sed -i "s/appVersion: .*/appVersion: \"$$(cat internal/version/data/tag)\"/" %s/Chart.yaml`, helm.meta.HelmChartDir)) | ||
| generateTarget.Script(fmt.Sprintf(`@TAG=$$(cat internal/version/data/tag); \ |
There was a problem hiding this comment.
Added the non-final-release check to both branches - so, if the tag is not a final tag, we don't bump the appVersion in chart.
|
/m |
Bump all deps, self-rekres.