Skip to content

chore: enable lefthook regardless of CompileGithubWorkflowsOnly#673

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
majabojarska:chore/allow-lefthook-when-only-gh-ci
Jul 1, 2026
Merged

chore: enable lefthook regardless of CompileGithubWorkflowsOnly#673
talos-bot merged 1 commit into
siderolabs:mainfrom
majabojarska:chore/allow-lefthook-when-only-gh-ci

Conversation

@majabojarska

@majabojarska majabojarska commented Jul 1, 2026

Copy link
Copy Markdown
Member

Currently the Lefthook output will be compiled only when CompileGithubWorkflowsOnly is false. We actually want to generate the lefthook.yml always, regardless of the GH workflow flag.

make rekres creates zero-diff.

This still won't generate a meaningful config for Talos, but that's a separate problem.

Currently Lefthook output will be compiled only when
CompileGithubWorkflowsOnly is falsy. We actually want to generate the
lefthook.yml always, regardless of the GH workflow flag.

Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
@majabojarska majabojarska self-assigned this Jul 1, 2026
@github-project-automation github-project-automation Bot moved this to To Do in Planning Jul 1, 2026
@talos-bot talos-bot moved this from To Do to In Review in Planning Jul 1, 2026
@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Jul 1, 2026
@majabojarska

Copy link
Copy Markdown
Member Author

/m

@talos-bot talos-bot merged commit d98557c into siderolabs:main Jul 1, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning Jul 1, 2026
@majabojarska majabojarska deleted the chore/allow-lefthook-when-only-gh-ci branch July 1, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants