chore: revert "chore: allow lefthook when CompileGitHubWorkflowsOnly"#674
Merged
talos-bot merged 1 commit intoJul 1, 2026
Merged
Conversation
majabojarska
force-pushed
the
chore/lefthook-gh-workflows-rev
branch
from
2c56d6d to
5939bf5
Compare
Turns out the Talos-side configuration is way more blocking for having auto-generated `lefthook.yml` than I anticipated. The Makefile/golang outputs are not generated for Talos, they're hand-written and maintained. Therefore, the `CompileLefthook` callables attached to these outputs never execute, leading to an effectively empty lefthook.yml (just an empty JSON document `{}`).
For the time being, it's far more viable to manually add a lefthook config for Talos. Having that config generated for "GH workflow only" would wipe the lefthook.yml on every `make rekres`. Therefore, we need to revert this change.
Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
majabojarska
force-pushed
the
chore/lefthook-gh-workflows-rev
branch
from
5939bf5 to
3c738c6
Compare
smira
approved these changes
Jul 1, 2026
Member
Author
|
/m |
talos-bot
pushed a commit
to siderolabs/talos
that referenced
this pull request
Jul 1, 2026
See siderolabs/kres#674 for more context on why the lefthook.yml in Talos is not generated by kres. Signed-off-by: Maja Bojarska <maja.bojarska@siderolabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d98557c.
Turns out the Talos-side configuration is way more blocking for having auto-generated
lefthook.ymlthan I anticipated. The Makefile/golang outputs are not generated for Talos, they're hand-written and maintained. Therefore, theCompileLefthookcallables attached to these outputs never execute, leading to an effectively empty lefthook.yml (just an empty JSON document{}).For the time being, it's far more viable to manually add a lefthook config for Talos. Having that config generated for "GH workflow only" would wipe the lefthook.yml on every
make rekres. Therefore, we need to revert this change.