Skip to content

feat(frontend): show join tokens in saved presets list#2910

Merged
talos-bot merged 1 commit into
siderolabs:mainfrom
Slessi:join-tokens-installation-media-list
Jun 2, 2026
Merged

feat(frontend): show join tokens in saved presets list#2910
talos-bot merged 1 commit into
siderolabs:mainfrom
Slessi:join-tokens-installation-media-list

Conversation

@Slessi

@Slessi Slessi commented May 29, 2026

Copy link
Copy Markdown
Member

On the saved presets list for installation media, show the selected join token and any relevant badges about it.

Closes #2716

image

@frezbo

frezbo commented May 29, 2026

Copy link
Copy Markdown
Member

what's an invalid token since it's omni which creates it?

@Slessi

Slessi commented May 29, 2026

Copy link
Copy Markdown
Member Author

@frezbo it means the token specified in the preset doesnt exist, its currently just a copy of the raw token itself inside the preset

maybe you deleted it, or maybe it was added through CLI as a yaml apply, and it never existed in the first place

name could be better... wasnt sure if "deleted" was correct since it might never have existed... could be "Not found" ?

@Unix4ever

Unix4ever commented May 29, 2026

Copy link
Copy Markdown
Member

I don't like that we have 3 different ways to display that:
Automatic (%token name%)
%token name% Expired
Invalid token

Lets maybe pick a single style for that.
Maybe something like:
%token name% Automatic
%token name% Expired
%token name% Revoked
%token name% Deleted

Automatic can be green, Expired, Revoked and Deleted can be red with ! in a triangle icon.

@rothgar

rothgar commented May 29, 2026

Copy link
Copy Markdown
Member

What does "Automatic" mean for join tokens?

@Slessi

Slessi commented May 30, 2026

Copy link
Copy Markdown
Member Author

@rothgar isn't fixed to a specific one and will always use default

@Slessi

Slessi commented Jun 1, 2026

Copy link
Copy Markdown
Member Author

@Unix4ever I can't show a token name for deleted because I can't know what the token name was, and there are also tokens that are directly specified (so no label to add), so it will be this

  • %token name%
  • %token name% Automatic
  • %token name% Expired
  • %token name% Revoked
  • Deleted

Regarding Deleted: Might never have existed, as far as i see we have no join token validation, so you can add bad tokens that never existed, but im ok to ignore that nuance and use deleted

I will use green automatic label for talos version also, as I copied Automatic (*) from there

image

@github-project-automation github-project-automation Bot moved this from In Review to Approved in Planning Jun 1, 2026
On the saved presets list for installation media, show the selected join token and any relevant badges about it.

Signed-off-by: Edward Sammut Alessi <edward.sammutalessi@siderolabs.com>
@Slessi

Slessi commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

/m

@talos-bot talos-bot merged commit 429708f into siderolabs:main Jun 2, 2026
55 of 56 checks passed
@github-project-automation github-project-automation Bot moved this from Approved to Done in Planning Jun 2, 2026
@Slessi Slessi deleted the join-tokens-installation-media-list branch June 2, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[feature] show join token status in installation media screen

5 participants