feat: add support for orange pi 5 max (rebase of #77) #84
Conversation
|
this is awesome, I was just looking for exactly this (how timely) and am happy to see that you folks already took care of it. I mainly comment to express gratitude and give a counter-example of the apparent non-popularity of this board 😄. having support would make a pretty sweet talos node out of this orange pi 5 max (I assume ultra would also work with this PR merged, as the hardware is extremely similar. will test this out once it's released). |
|
|
||
| steps: | ||
| - sources: | ||
| - url: https://cdn.kernel.org/pub/linux/kernel/v{{ regexReplaceAll "(\\d+)(.\\d+)(\\.\\d+)?$" .linux_orangepi5max_version "${1}" }}.x/linux-{{ .linux_orangepi5max_version }}.tar.xz |
There was a problem hiding this comment.
where's linux_orangepi5max_version defined? I can;t seem to find it
There was a problem hiding this comment.
if the dtb is there in upstream 6.17 kernel, we could just pull it in
There was a problem hiding this comment.
It looks like I messed up the rebase and lost linux_orangepi5max_version. It was there initially https://github.com/siderolabs/sbc-rockchip/pull/77/files#diff-4dedc27acfbaae8cce2bf60065f00438edce56ae56b22ed46d099f91f0f1fd15R35
Ill get this fixed.
Is there an easy way to tell if the dtb is in the upstream 6.17 kernel? Im very new to this and am also looking for how to test this code change on my device.
There was a problem hiding this comment.
the dtb's are there in the 6.17 kernel, this was doing patches on top of it, not sure if we need it
There was a problem hiding this comment.
since I don't see a patches folder here
There was a problem hiding this comment.
It does appear that it is in kernel 6.17. Ill go remove this and the var thats being referenced..
There was a problem hiding this comment.
I pushed the removal as a separate commit since the authors changed. I can squash them together if that is what is preferred here.
added support for Orange Pi 5 Max updated uboot_rk1 version to 2025.07 -- needed for Orange Pi 5 Max updated Orange Pi 5 Plus patches and Turing rk1 patches due to the newer uboot_rk1 Signed-off-by: alardev <[email protected]> Signed-off-by: Noel Georgi <[email protected]> Signed-off-by: Paul Robertson <[email protected]>
perobertson
force-pushed
the
alardev-main
branch
from
d70c11d to
5de0b79
Compare
kernel 6.17 contains the dtb Signed-off-by: Paul Robertson <[email protected]>
| uboot_sha512: 01ac8b2b36bd73b7accc22afd20cf45d08ff8ece6a3d1c426ec90936d1767245add92572cc162500b2160bbc0e2ceed3e111a2a0dd35f8f3a86edbd4fc78753c | ||
|
|
||
| # renovate: datasource=github-tags extractVersion=^v(?<version>.*)$ depName=u-boot/u-boot | ||
| uboot_rk1_version: 2025.01 |
There was a problem hiding this comment.
https://docs.u-boot.org/en/v2025.07/board/rockchip/rockchip.html was the first version to mention orangepi-5-max.
It seems like 2025.10 is out now too. This article suggests there were performance improvements on arm
It seems like scope creep for this PR so it can be upgraded later if needed.
There was a problem hiding this comment.
The original PR had this modification to orangepi-5-plus. Should it be reverted since its a different device?
There was a problem hiding this comment.
The original PR had this modification to orangepi-5-plus. Should it be reverted since its a different device?
4 participants
added support for Orange Pi 5 Max
updated uboot_rk1 version to 2025.07 -- needed for Orange Pi 5 Max updated Orange Pi 5 Plus patches and Turing rk1 patches due to the newer uboot_rk1
This is just a rebase of #77 onto the latest main. @alardev and @frezbo did all of the work here.