feat: add k8s-version parameter to k8s-bundle #12512
Open
+199
−68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanduur
force-pushed
the
feat/k8s-version-bundle
branch
from
a2d8740 to
14cdbd3
Compare
Allow overriding K8s version in the command. Signed-off-by: Mateusz Urbanek <[email protected]>
shanduur
force-pushed
the
feat/k8s-version-bundle
branch
from
14cdbd3 to
cc2dd36
Compare
smira
reviewed
Dec 29, 2025
| })) | ||
| ) | ||
|
|
||
| // if k8sVersion is defined, then we don't print components versions - there's no simple way to correlate patch-to-patch. |
Member
There was a problem hiding this comment.
these versions are set by Talos, and they don't depend on Kubernetes version?
I'm trying to understand why we don't print them
Member
Author
There was a problem hiding this comment.
I wonder if we should be printing them at all here - should those be part of talos-bundle? If so, how do we ensure that we print correct version when overriding Talos version?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding K8s version in the command.
Closes #12257
Signed-off-by: Mateusz Urbanek [email protected]